Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottleneck Problem while Inserting Data with a High Number of Relationships #782

Open
loperia2 opened this issue Jun 28, 2022 · 0 comments

Comments

@loperia2
Copy link

Describe the bug

When I want to save a JSON:API standard data containing 2000 included record to vuex orm, Screenshot from 2022-06-28 14-37-55
with vuex-orm-json-api:
Screenshot from 2022-06-28 14-42-27
I experience waits of up to 20 seconds.

When I try to deserialize the data with the JSONA package and save it like this:
Screenshot from 2022-06-28 14-45-20
I get maximum call stack size exceeded error. Because of this fuction from @vuex-orm-core/core/dist/vuex-rom.esm.js:
Screenshot from 2022-06-28 14-55-57
When you comment out the if conditions here, the wait time drops from 20 seconds to 4 seconds.

Expected behaviour

Can the waiting time be shortened for data with a large number of relations? If this cannot be done, can it be made optional to use the cloneDeep function?

Versions

  • vuex-orm-json-api: 0.9.7
  • Vuex ORM: 0.36.4
  • Vue: 2.6.13

Link to minimal reproduction

CodeSandbox

Additional context

Add any other context about the bug here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant