Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Margin on CmsBlockTextOnImage is set as margin instead of padding #1966

Open
1 task done
bitfactory-frank-spee opened this issue Nov 8, 2022 · 0 comments
Open
1 task done
Labels
bug Something isn't working Good First Issue

Comments

@bitfactory-frank-spee
Copy link

What happened?

On the 'text-on-image' block (CmsBlockTextOnImage) I expected to see the margins as padding instead of as margins on the <article> node. These styles are generically set through the CmsGenericBlock. But are not correct for at least this specific block.

In the front-end of the Shopware installation this block is shown as with padding instead as margin. And looks the same as the preview in the CMS itself. Although they are still called margin's in the CMS aswell (which is odd too).

I would even expect it to work for other blocks aswell with padding's. But I am not sure about the Shopware behaviour on other blocks.

Might be related to: #1286

Steps To Reproduce

  1. In the CMS on a layout set a Hero Image (text-on-image) from the Text & Images category.
  2. Give the block a background image or color
  3. Set the layout margins on the block
  4. The preview in the CMS suggests padding instead of margins on the block
  5. Check Shopware storefront generated html with styles (it is padding)
  6. Check Shopware PWA Headless storefront generated html (it is margins)

Is there an existing issue for this?

  • I have searched the existing issues

Version

Latest stable (generated by CLI)

Which element is affected?

default-theme

Environment

- OS: Docker
- Node: 16.18
- Shopware API: 6
- Shopware PWA version: 1.5.3

Relevant log output

No response

@bitfactory-frank-spee bitfactory-frank-spee added the bug Something isn't working label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Good First Issue
Projects
None yet
Development

No branches or pull requests

2 participants