Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove hardcoded Google Fonts #1945

Open
2 tasks
bow-sb opened this issue Aug 29, 2022 · 1 comment
Open
2 tasks

[FEATURE] Remove hardcoded Google Fonts #1945

bow-sb opened this issue Aug 29, 2022 · 1 comment

Comments

@bow-sb
Copy link
Contributor

bow-sb commented Aug 29, 2022

Description

A German court has ruled that Google Fonts are not GDPR compliant. It would be better to remove the hardcoded inclusion and add a notice to the installation instructions, the same way Storefront UI handles it currently.

Court decision (German)
Article about Google Fonts (English)

Acceptance criteria

  • Remove Google Fonts from project
  • Add instructions for usage to docs
@super-kamil
Copy link

Here is a workaround for this until it gets removed:

nuxt.config.js

import extendNuxtConfig from "@shopware-pwa/nuxt-module/config";
const defaultConfig = extendNuxtConfig();

// remove default fonts Raleway and Roboto
defaultConfig.head.link = defaultConfig.head.link.filter((link) => {
  return !(
    link.href &&
    (link.href.includes("Roboto") || link.href.includes("Raleway"))
  );
});

This can be applied to Google Fonts as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants