Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location macro doesn't include scheme, host or port information #148

Open
coryodaniel opened this issue Aug 4, 2016 · 1 comment
Open

Comments

@coryodaniel
Copy link
Contributor

Currently the location macro doesnt include the scheme, host or port number of the request. I can see how this makes sense when consuming an API, obviously you already know that information :D

Curious if anyone else sees any value in having an option to output just the path or the full url based on the conn's current information?

@alanpeabody
Copy link
Contributor

Hey @coryodaniel, thanks for opening this issue. I am in totally agreement that the url/link/location stuff isn't good enough.

I haven't yet had an opportunity to dig into this, but it would be awesome to be able to pass a anonymous function in anywhere we expect a location. That would allow users to use the generated Phoenix.Router _path or _url functions to build urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants