Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Involved #4

Open
RichieBzzzt opened this issue Apr 9, 2020 · 1 comment
Open

Getting Involved #4

RichieBzzzt opened this issue Apr 9, 2020 · 1 comment

Comments

@RichieBzzzt
Copy link
Contributor

Hello!

I forked and made some changes to the make_db scripts and had to do a few other updates as the underlying website had been re-designed so the database could no longer be rebuilt.

I've got the changes here ready to go; you happy for me to raise a PR?

https://github.com/richiebzzzt/pokemon

I've tested that it works on Windows 10, Ubuntu and even a Databricks Cluster! My test package is on pypi (clefairy)

Thanks for creating this, it's great!

@vsoch
Copy link
Owner

vsoch commented Apr 9, 2020

Yes a PR would be great! Thanks for fixing things up, I haven’t looked at this guy in a while (but have used many times over the years).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants