Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: text with diacritic marks does not highlight properly #1900

Open
3 tasks done
ollien opened this issue Apr 21, 2024 · 0 comments
Open
3 tasks done

bug: text with diacritic marks does not highlight properly #1900

ollien opened this issue Apr 21, 2024 · 0 comments
Labels
bug Something isn't working category: localisation Issues regarding language and keyboard compatibility category: visual related to highlights, selections, etc

Comments

@ollien
Copy link
Collaborator

ollien commented Apr 21, 2024

Check the following:

  • I have checked the behavior after setting "vscode-neovim.neovimClean" in VSCode settings.
  • I have read the vscode-neovim docs.
  • I have searched existing issues.

Neovim version (nvim -v)

v0.9.5

Operating system/version

Fedora 39

Describe the bug

Text with diacritic marks do not highlight their full character width. This mostly affects the subset of unicode where we combine base letters with diacritic marks (i.e. what Zalgo text uses; https://en.wikipedia.org/wiki/Combining_Diacritical_Marks), rather than the standalone characters like à.

I'll admit that this is likely not that prevalent in code, but I found it by accident and figured it was better in a bug tracker than in my head. I suspect this is somewhat related to #1367

Steps To Reproduce

  1. Create a document with the following content
ȯo ȯo
őo őo
  1. Place your cursor on the first character of any line, and press *
  2. Notice that the highlight is a narrow width, rather than the actual character width

image

Expected Behavior

The entire character should be highlighted. Plain neovim handles this case correctly

image

@ollien ollien added the bug Something isn't working label Apr 21, 2024
@ollien ollien changed the title bug: text with diacritic do not highlight properly bug: text with diacritic marks do not highlight properly Apr 21, 2024
@ollien ollien changed the title bug: text with diacritic marks do not highlight properly bug: text with diacritic marks does not highlight properly Apr 21, 2024
@justinmk justinmk added the category: visual related to highlights, selections, etc label Apr 21, 2024
@theol0403 theol0403 added the category: localisation Issues regarding language and keyboard compatibility label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: localisation Issues regarding language and keyboard compatibility category: visual related to highlights, selections, etc
Projects
None yet
Development

No branches or pull requests

3 participants