feat: fully support the "guicursor" option

[tmpm697]

Check the following:

• I have checked the behavior after setting "vscode-neovim.neovimClean" in VSCode settings.
• I have read the vscode-neovim docs.
• I have searched existing issues.

Neovim version (nvim -v)

NVIM v0.9.4

Operating system/version

macos ventura 13.6.6

Describe the bug

I have this option: vim.o.guicursor = "a:ver100", epxect all cursor shape of all modes will be | but the visual/selecting mode still have block cursor shape.

Steps To Reproduce

just have above option in neovim config

Expected Behavior

epxect all cursor shape of all modes will be |

[justinmk]

confirmed w/ NVIM v0.10.0 9765efb40f5

[theol0403]

It's because we hardcode the cursor style in visual mode. It is a "fake" cursor that is shown through the highlight provider, not the cursor provider.

vscode-neovim/runtime/lua/vscode-neovim/cursor.lua

Line 138 in b39552c

fake_cursor = api.nvim_buf_set_extmark(0, fake_cursor_ns, line - 1, col - 1, {

I'm not even sure if the highlight API allows for cursor-like highlights.

[theol0403]

@tmpm697 the primary cursor is the real cursor rendered in VSCode, which is actually the "primary selection" with 0 width. In vim visual mode, the selection and the cursor are two separate entities. To select the correct text, the vscode cursor is used for the selection, and a fake cursor is shown to represent the vim cursor.

We keep track of user's cursor settings for the main cursor:

vscode-neovim/src/cursor_manager.ts

Line 132 in f7f8938

this.cursorModes.set(mode.name, { cursorShape: mode.cursor_shape });

vscode-neovim/src/cursor_manager.ts

Lines 156 to 170 in f7f8938

	const modeConf = this.cursorModes.get(modeName);
	if (!modeConf) {
	return;
	}
	let style: TextEditorCursorStyle;
	if (modeName == "visual") {
	// in visual mode, we try to hide the cursor because we only use it for selections
	style = TextEditorCursorStyle.LineThin;
	} else if (modeConf.cursorShape === "block") {
	style = TextEditorCursorStyle.Block;
	} else if (modeConf.cursorShape === "horizontal") {
	style = TextEditorCursorStyle.Underline;
	} else {
	style = TextEditorCursorStyle.Line;
	}

[xiyaowong]

Currently, it's difficult to find a concise implementation method. "fake_cursor" is essentially just a special "highlight" without targeted handling logic in vscode. To fully support the "guicursor" option, we'd need to maintain a vscode decorator serving as the cursor, updating its color, shape, position, etc.