Avoid unneeded file copying

[htj]

Currently vmx and vqfx (maybe more), copy the image files from the base directory into the docker directory.

This often means copying a few gigabytes of files. While disk space is fairly cheap, it seems silly, and just makes the build process take longer time.

AFAIK there is no reason that a seperate docker directory is needed. I suggest we can simply move the files in docker/* to the base directory and build directly from the files there. There is typically very few files in both directories anyway, so I don't think it will clutter.

Thoughts?

[hellt]

Agree, this seems like a viable approach

[plajjan]

The reason is that when you have 7 (pick a number!) VMX files, you don't want all of them included in your docker build context (that gets sent to the docker daemon). Copying the currently selected file over to the docker directory means we send less to the docker daemon (which is the slower step).

[hellt]

I tend to believe that high number of images you keep in scope of vrnetlab repo stems from the fact that you keep the images within the repo. My gut feeling is that most of the users don't do this, and rather copy a single image to the build stage and discard it later. Moreover, I expected to see qcow2 to be gitignored, but, then again, that contradicts with the workflow when images are stored within the repo

…

On Mon, Jan 18, 2021 at 9:10 PM Kristian Larsson ***@***.***> wrote: The reason is that when you have 7 (pick a number!) VMX files, you don't want all of them included in your docker build context (that gets sent to the docker daemon). Copying the currently selected file over to the docker directory means we send less to the docker daemon (which is the slower step). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLKV5ILBCKUBAFBYQQAQGTS2SISFANCNFSM4PXRQ5UQ> .