Vqfx qcow #234
Open
Vqfx qcow #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 6, 2020 13:30
…and use explicit version names inside docker images
plajjan
reviewed
Feb 1, 2021
| echo "image $(IMAGE)" | ||
| echo "version $(VERSION)" | ||
|
|
||
| # mostly copied from makefile.include, i wish this was easier to change |
There was a problem hiding this comment.
Why do you need to copy this. What is it that you want to change / inject? Turn whatever that is into a variable?
There was a problem hiding this comment.
Hi Kristian. I've changed jobs, so probably won't spend anymore time on this. Hope all is well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vqfx_cleanup should be merged first
This vqfx works with new images and switches to qcow so no conversion it necessary.
Uses a more explicit version/naming scheme to avoid to much guessing. I really hate regexes.
Fixes #221