Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the code #163

Open
whyme0 opened this issue Mar 28, 2020 · 1 comment
Open

Simplify the code #163

whyme0 opened this issue Mar 28, 2020 · 1 comment

Comments

@whyme0
Copy link

whyme0 commented Mar 28, 2020

if extra_fields.get('is_staff') is not True:
raise ValueError('Superuser must have is_staff=True.')
if extra_fields.get('is_superuser') is not True:

Why it's not better to use False instead not True?

@vreaxe
Copy link
Owner

vreaxe commented Mar 29, 2020

Thank you so much for your suggestion. I think you are right.
Feel free to make a pull request to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants