Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo is not working #828

Open
xiongxoy opened this issue Feb 27, 2020 · 3 comments
Open

Undo is not working #828

xiongxoy opened this issue Feb 27, 2020 · 3 comments
Labels

Comments

@xiongxoy
Copy link

Undo is not working in Vrapper 0.74.0 for pom.xml, but it works fine in java files

Eclipse IDE for Enterprise Java Developers.
Version: 2019-12 (4.14.0)
Build id: 20191212-1212

@albertdev
Copy link
Member

Thank you for your report. I can indeed reproduce the issue, and there are no errors in the log so something must be silently going wrong.

The strange thing is that Vrapper's undo functions work for regular XML, so maybe the Maven POM file editor is doing something special. This will need further investigation...

@alex1701c
Copy link

I have the similar issue that the undo command (when vrapper is enabled) is different that if it is disabled.

It somehow deletes more code, if you for instance create a new line and type some stuff it removes the entired line.

eclipse_vrapper

Hopefully this helps 😄

@albertdev
Copy link
Member

@alex1701c The issue in this ticket was only reproducible in the Maven POM editor while your screen capture is clearly about a Java file. I believe this is unrelated, so if you have further concerns then I would prefer if you made a new ticket please.

Anyway, it seems your cursor does not change back to the black "block" cursor which I would normally expect when you press Esc to exit Insert mode. It is normal Vim behaviour that the undo command will undo everything you typed during a single "Insert mode session", so if you want to have several "undo steps" you should press Esc and then i more often.

Because the cursor didn't change I would also assume you triggered the undo command using Ctrl+Z? Please be aware that this never gets tested because it is assumed that you use Esc and then u like in Vim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants