Cannot specify error_log severity for server definitions without overriding the auto-generated, undocumented error_log directive

[ltning]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.x
• Ruby: 2.6.x
• Distribution: FreeBSD
• Module version: 2.0.0

How to reproduce (e.g Puppet code you use)

Any nginx server definition

What are you seeing

error_log has an undocumented, magically constructed default value, and there is no way to add severity flag on a per-server level without losing the automatically named error_log.

What behaviour did you expect instead

1. Documented auto-naming of server-level error_log
2. Ability to specify per-server error_log severity
3. Examples of how to specify error_log achieving the same as what the template does

Note that for 3) above, it is already understood that in explicit server definitions, error_log can be given easily. The problem is that our server definitions are template-based and auto-generated (in the thousands), so there is no way for us to specify the error_log explicitly for each. In the hiera template used for the server definitions we don't have access to the generated title (right?) and nginx does not support using server variables in error_log statements.

[ltning]

The following change to templates/server/server_ssl_header.erb does the trick; probably needed in other templates too:

-  error_log             <%= scope['::nginx::config::log_dir'] %>/ssl-<%= @name_sanitized %>.error.log;
+  error_log             <%= scope['::nginx::config::log_dir'] %>/ssl-<%= @name_sanitized %>.error.log <%= scope['::nginx::nginx_error_log_severity'] %>;