Support for an offline/file based mirror

[LyndonArmitage]

This is just a suggestion (as my puppet knowledge is quite limited).

It might be useful to add in the ability to use a puppet file server URI as a mirror instead of assuming an online mirror, as in some installs there will not be a connection available to the internet.

I've currently tried to add alter the code to support this by:

Removing the validate_re call and replacing it with a variable called $mirror_type that determines if a mirror is a HTTP URL (suitable for the current wget based download) or a file based URI (like puppet://my-module/ or /vagrant/deps):

  $mirror_type = $mirror_url ? {
    /^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/ => 'http',
    default                                                          => 'file',
  }

Then altering the install logic to use a File resource instead of the Exec resource when pointing at a file based mirror:

  if $mirror_type == 'http' {

    if ! defined(Package['wget']) {
      package {'wget':
        ensure => present,
      }
    }

    notify { "Downloading Kafka via http mirror ${package_url}": }->

    exec { 'download-kafka-package':
      command => "wget -O ${package_dir}/${basefilename} ${package_url} 2> /dev/null",
      path    => ['/usr/bin', '/bin'],
      creates => "${package_dir}/${basefilename}",
      require => [ File[$package_dir], Package['wget'] ],
    }

    $required_get_step = Exec['download-kafka-package']

  } else {

    notify { "Downloading Kafka via file mirror ${package_url}": }->

    file { 'get-kafka-package':
      source  => $package_url,
      path    => "${package_dir}/${basefilename}",
      owner   => 'kafka',
      group   => 'kafka',
      require => [ File[$package_dir], User['kafka'] ],
    }

    $required_get_step = File['get-kafka-package']
  }

  exec { 'untar-file-kafka-package':
    command => "tar xfvz ${package_dir}/${basefilename} -C ${install_directory} --strip-components=1",
    creates => "${install_directory}/LICENSE",
    alias   => 'untar-kafka',
    require => [ $required_get_step, File['kafka-app-dir'] ],
    user    => 'kafka',
    path    => ['/bin', '/usr/bin', '/usr/sbin'],
  }

If you're interested I can create a pull request later this week to illustrate this better?

[danimesq]

@LyndonArmitage Too you can accept good pull requests instead of ignoring me for one year.
Btw, good idea supporting offline installs in this repo.
Use Intranet to installs, what think about?

[LyndonArmitage]

Apologies @DaniellMesquita I have left a comment on that pull request now!

[dhoppe]

Since we are using the module voxpupuli/puppet-archive instead of wget, it should be possible to use a different source than http. I think we just need to update the validation of the parameter mirror_url.

[ffrank]

Instead of populating the $required_get_step, please add a before => Exec['untar-file-kafka-package'] to the respective retrieval resource.

[Bialogs]

Since the module is using puppet-archive there is the flexibility to specify a fully-custom mirror_url.

However in these lines, if my offline package does not end in tgz the package_url is downloaded as the default case, which again makes assumptions about how I've named the offline kafka package.

To support the varied configurations of offline downloads, is it possible to modify the module so that mirror_url is passed directly into source when provided by the user. Or can the module support an additional parameter that offers this customization?