Add a parameter to package mark hold #1177
Closed
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phaedriel
force-pushed
the
package_hold
branch
3 times, most recently
from
d56d1df
to
7128800
Compare
smortex
reviewed
Dec 16, 2022
manifests/package.pp
Outdated
| package { 'elasticsearch': | ||
| ensure => $package_ensure, | ||
| name => $elasticsearch::_package_name, | ||
| mark => ($elasticsearch::autoupgrade ? { true => 'none', false => 'hold', }), |
There was a problem hiding this comment.
Not sure if re-using $elasticsearch::autoupgrade is a good idea. Of course if one wants updates to be automatically installed holding the package does not make sense, but otherwise one will probably want to know if updates are available.
What do you think about adding a new parameter like $elasticsearch::package_hold?
There was a problem hiding this comment.
Ok but i will do this modification when i come back after my holidays ;) (i have only my ipad actually)
phaedriel
force-pushed
the
package_hold
branch
from
7128800
to
3296505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add attribut 'mark' on resource package
This Pull Request (PR) fixes the following issues
Fixes #1133