Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More "random" for thumb/timelens filenames #78

Open
derchrisuk opened this issue Nov 4, 2019 · 2 comments
Open

More "random" for thumb/timelens filenames #78

derchrisuk opened this issue Nov 4, 2019 · 2 comments
Milestone

Comments

@derchrisuk
Copy link
Member

We had an issue with recent Media releasing for JH.
All of JH content is being merged into a single Media Conference:

https://media.ccc.de/c/jh19

Because each of them were using their own schedule, there were several duplicate "Fahrplan" IDs.
As a result, the last Event releasing files to Media was overriding the timelens and thumb files for these duplicate IDs.
Example:

https://media.ccc.de/v/jh19-ulm-1001-lightning_talk_einfuehrung_in_zulip
https://media.ccc.de/v/jh19-hd-1001-cross_plattformen_mit_flutter

As you can see JH Ulm was last to upload with duplicate ID 1001.
And JH Heidelberg is now showing up with same thumb/timelens images.

Media itself can handle the duplicate IDs, but the thumb/timelens images are only relying on the ID it seems.

So my idea would be to implement more "random" into the thumb/timelens filenames, so they will become unique even in a situation when there are duplicate IDs in a single Media Conference.

@a-tze
Copy link
Contributor

a-tze commented Nov 4, 2019

"Random" is really not a good description. Lets call it "divert".

Beside that, the general discussion that needs to take place is, if we want to allow non-unique Fahrplan-IDs, because thats the real thing here.

And well.. it's called ID for a reason. Lets not mix cause and cure. The actual wishlist item here is "I want multiple tracker projects to be published into one media project without any conflicts".

@derpeter
Copy link
Contributor

derpeter commented Nov 4, 2019

At first mixing to projects with douplicate IDs is a bad idear an should be fixed be not having duplicate IDs.

But we can't prevent people from doing it so instead of adding random which makes many things much harder we can add the project slug to the fileneme. As this is at least tracker wide unique we should not run into this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants