Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoctoGui does not embed imagesinks on Wayland #286

Open
derpeter opened this issue Nov 20, 2020 · 3 comments
Open

VoctoGui does not embed imagesinks on Wayland #286

derpeter opened this issue Nov 20, 2020 · 3 comments
Labels

Comments

@derpeter
Copy link
Contributor

On ubuntu 20.10 the video displays in the gui appear as seperate windows instead docked in UI.
This broken for x xv gl and vaapi surfaces.

To make this more fun the glade editor shipped with 20.04 crashes on the ui file.

@saerdnaer saerdnaer added the bug label Jul 1, 2022
@danimo
Copy link
Contributor

danimo commented Jul 9, 2022

This may be an issue with Wayland being the default on Ubuntu now. Voctomix is not yet compatible with Wayland and tries to XEmbed the imagesinks, which is bound to fail.

@danimo
Copy link
Contributor

danimo commented Jul 9, 2022

At least Glade no longer crashes under Wayland in 22.04 :)

@danimo
Copy link
Contributor

danimo commented Jul 9, 2022

Here is a proposal on how to do it with glimagesink: https://gist.github.com/jonasl/92c1ef32cfd87047e15f5ae24c6b510e. This needs to replace the self.imagesink.set_window_handle(self.xid) logic in òn_syncmsg` required for XEmbed. Requires refactoring into two classes with different embed strategies, and with an interchangeable imagesink.

@danimo danimo changed the title Players not docking in voctogui on ubuntu 20.10 VoctoGui does not embed imagesinks on Wayland Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants