New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove commented code #921
Comments
If I'm not mistaken, that commented out code was still being ported over. (though that particular section might be done and finished) Generally I would agree with you there though and to be frank I had the exact same thought until I read the comments that go along with the commented code and connected it to the port to dotnet core that they were apparently still in the middle of. From what I can see that commented out stuff is all over the place (search all solution for CORE_PORT and you'll see what I'm talking about, I found 66 instances of that comment tag scattered throughout) |
Maybe conditional compilation statements would make more sense in that context. Even so I'd think using a branch would be better suited for that. |
https://github.com/voat/voat/blob/Core/src/Voat.UI/Controllers/AccountController.cs#L148
Do not commit code that's been commented out. If you need the code, use the version control history.
Future you wont know why you've left the code there.
Edit 1: Also this
https://github.com/voat/voat/blob/Core/src/Voat.UI/Controllers/AccountController.cs#L418
The text was updated successfully, but these errors were encountered: