Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include additional files to compute tmpfs size #8618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include additional files to compute tmpfs size #8618

wants to merge 1 commit into from

Conversation

YanzhaoLi
Copy link
Member

Fixes #8616

@YanzhaoLi YanzhaoLi requested a review from a team as a code owner February 11, 2020 10:17
@YanzhaoLi YanzhaoLi mentioned this pull request Feb 11, 2020
Open
@codecov-io
Copy link

Codecov Report

Merging #8618 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #8618     +/-   ##
=========================================
- Coverage   31.48%   31.39%   -0.1%     
=========================================
  Files         293      293             
  Lines       44392    44392             
=========================================
- Hits        13979    13937     -42     
- Misses      29188    29233     +45     
+ Partials     1225     1222      -3
Impacted Files Coverage Δ
lib/portlayer/attach/communication/lazy.go 68.18% <0%> (-22.73%) ⬇️
lib/portlayer/attach/communication/connector.go 54.2% <0%> (-7.48%) ⬇️
pkg/logmgr/logmgr.go 62.79% <0%> (-5.43%) ⬇️
lib/portlayer/attach/communication/interactor.go 24.08% <0%> (-2.92%) ⬇️
lib/portlayer/event/subscriber.go 92.2% <0%> (-2.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9becae4...6b15207. Read the comment docs.

@jakedsouza
Copy link
Contributor

Codecov Report

Merging #8618 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8618      +/-   ##
==========================================
- Coverage   31.48%   31.39%   -0.10%     
==========================================
  Files         293      293              
  Lines       44392    44392              
==========================================
- Hits        13979    13937      -42     
- Misses      29188    29233      +45     
+ Partials     1225     1222       -3
Impacted Files Coverage Δ
lib/portlayer/attach/communication/lazy.go 68.18% <0.00%> (-22.73%) ⬇️
lib/portlayer/attach/communication/connector.go 54.20% <0.00%> (-7.48%) ⬇️
pkg/logmgr/logmgr.go 62.79% <0.00%> (-5.43%) ⬇️
lib/portlayer/attach/communication/interactor.go 24.08% <0.00%> (-2.92%) ⬇️
lib/portlayer/event/subscriber.go 92.20% <0.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9becae4...6b15207. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bootstrap.iso for rhel 7.7 having some issues
4 participants
@YanzhaoLi @codecov-io @jakedsouza @vmwclabot