Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for injecting podLabels to the daemonset when deploying using the helm-chart #422

Open
gilles-o opened this issue Sep 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@gilles-o
Copy link

Is your feature request related to a problem? Please describe.

What?

The current Helm-Chart does not support extraLabels on the pods of the daemonset.

We're using your awesome fluentd operator in an azure-AKS context, where we use workload-identity (a built-in mechanism that allows azure-authentication of pods via managed-identities) to give pods access to various azure resources (retrieving secrets from azure key-vault, for instance.

Why?
In order to enable the workload-identity mechanism, it's mandatory to add a specific label to the concerned pods.

Describe the solution you'd like

What seems the easiest is to enable an optional podLabels via values.yaml that is applied to the daemonset resource.

Describe alternatives you've considered

No response

Additional context

No response

@gilles-o gilles-o added the enhancement New feature or request label Sep 27, 2023
@slimm609
Copy link
Contributor

Thanks for opening this. We are open to contributions for this if possible, otherwise we will work on prioritizing it properly

@gilles-o
Copy link
Author

Thanks for opening this. We are open to contributions for this if possible, otherwise we will work on prioritizing it properly

...I tried to do that, but as not able to push my branch into your repo... Nos sure what process I need to follow to be granted that permission...
Thanks for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants