Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected Plugin Parameters #308

Open
xelalexv opened this issue Mar 14, 2022 · 0 comments
Open

Protected Plugin Parameters #308

xelalexv opened this issue Mar 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@xelalexv
Copy link
Contributor

xelalexv commented Mar 14, 2022

Is your feature request related to a problem? Please describe.

The ability to define plugins as the cluster admin, for namespace admins to use, is a great feature. For the namespace admin, it simplifies the way in which to opt in to a particular log sink. For the cluster admin, it's easy to keep consistent log sink configs. Currently, however namespace admins can change all parameters of a given plugin simply by setting desired values. For certain parameters, that's desired. However, other parameters may need to be protected to ensure a secure and compliant log sink configuration.

Example: Using the Splunk HEC plugin, namespace admins should be able to define the hec_token parameter, but we would not want them to change the hec_host or hec_port parameters.

Describe the solution you'd like

As a cluster admin defining plugins, I want to be able to specify per parameter of the plugin whether the namespace admins using the plugin are allowed to change them.

This could be done by defining a protected prefix for parameter names, e.g. !. If present, the parameter is protected.

Example:

<plugin splunk>
    @type splunk_hec
    !hec_host splunk.acme.com
    !hec_port 8088
    !protocol https
    !insecure_ssl false
    ...
</plugin>

Here, use of the HEC endpoint host & port, as well as secure HTTPS access would be enforced.

Describe alternatives you've considered

No response

Additional context

I have played with this and created an implementation as outlined above. If there is interest in this feature, I can open a PR.

@xelalexv xelalexv added the enhancement New feature or request label Mar 14, 2022
xelalexv added a commit to xelalexv/kube-fluentd-operator that referenced this issue Mar 14, 2022
xelalexv added a commit to xelalexv/kube-fluentd-operator that referenced this issue Mar 24, 2022
xelalexv added a commit to xelalexv/kube-fluentd-operator that referenced this issue May 12, 2022
xelalexv added a commit to xelalexv/kube-fluentd-operator that referenced this issue Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant