Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows support #246

Open
maxsivkov opened this issue Sep 2, 2021 · 6 comments
Open

windows support #246

maxsivkov opened this issue Sep 2, 2021 · 6 comments

Comments

@maxsivkov
Copy link

Hello
Are kfo community users interested in windows-capable kfo?
Recently I built fluentd, reloader windows images and implemented windows nodes support in charts.
Up to now it works without major issues in our QA cluster running k8s v1.18.20 and nodes running Windows Server 2019 for two weeks or so.
PS
Tested only with elasticsearch output plugin.

@Cryptophobia
Copy link
Contributor

Cryptophobia commented Sep 8, 2021

Thank you for contributing by opening the issue @maxsivkov . Great news that it works on Windows k8s. If other users comment then we can have a special folder in the repo made for the configurations.

@maxsivkov
Copy link
Author

Thank you for contributing by opening the issue @maxsivkov . Great news that it works on Windows k8s. If other users comment then we can have a special folder in the repo mode for the configurations.

well, in my port I need not only to prepare Dockerfiles for base and reloader images, but also patch chart files and operator sources.
If my memory serves me right, I patched validator_test.go pass build on windows and reloader.go (enable fluentd /api/config.reload endpoint usage because there are plugins that do not support graceful reload)
Also I implemented an option to disable systemd (config and model)

@Cryptophobia
Copy link
Contributor

Cryptophobia commented Sep 13, 2021

Okay, we could stick that all into a folder windows/ in the root of the repo with short instructions on how to build and make the modifications? Or make a git patch file to apply for the changes also.

enable fluentd /api/config.reload endpoint usage because there are plugins that do not support graceful reload

Which plugins that you are using have you noticed do not support graceful reload endpoint? Most maintained plugins support the new graceful reload per specification.

@maxsivkov
Copy link
Author

maxsivkov commented Sep 13, 2021

Okay, we could stick that all into a folder windows/ in the root of the repo with short instructions on how to build and make the modifications? Or make a git patch file to apply for the changes also.

Well I can prepare patch or PR or series of PRs.

Which plugins that you are using have you noticed do not support graceful reload endpoint? Most maintained plugins support the new graceful reload per specification.

we use fluent-plugin-detect-exceptions in our configuration, and it does not support graceful reload
There is an issue opened in their repository for a while GoogleCloudPlatform/fluent-plugin-detect-exceptions#77

@Cryptophobia
Copy link
Contributor

Cryptophobia commented Sep 13, 2021

we use fluent-plugin-detect-exceptions in our configuration, and it does not support graceful reload
There is an issue opened in their repository for a while GoogleCloudPlatform/fluent-plugin-detect-exceptions#77

I think all they need to do is merge this one in and it will support new V1 fluentd API: GoogleCloudPlatform/fluent-plugin-detect-exceptions#45

Well I can prepare patch or PR or series of PRs.

Sure, I will review and approve if you do this work. :)
I cannot guarantee I will be able to test it out because we do not run windows nodes kubernetes.

@maxsivkov
Copy link
Author

Sure, I will review and approve if you do this work. :)
I cannot guarantee I will be able to test it out because we do not run windows nodes kubernetes.

Hello
Finally I prepared PR #264
Please read PR comment about how to build images and then prepare manifests

I was unable to split this PR to smaller pool requests because things are very relative...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants