Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are missing from pypi sdist #215

Open
dvzrv opened this issue Jan 10, 2020 · 1 comment
Open

tests are missing from pypi sdist #215

dvzrv opened this issue Jan 10, 2020 · 1 comment

Comments

@dvzrv
Copy link

dvzrv commented Jan 10, 2020

Hi! I'm packaging python-vmprof for Arch Linux. We usually use pypi as upstream (it has a more unique naming strategy when it comes to source tarballs).
However, when building 0.4.15 I noticed, that vmprof/test is missing from the sdist.

As during packaging usually all tests are run to ensure the compatibility with the system-wide provided versions of other python libraries and python itself, it would be really great to add the files to the sdist! Thank you!

@mattip
Copy link
Contributor

mattip commented Jan 3, 2024

I just released 0.4.17 and I see the tests are still not in the source tarball. I see there is some discussion about this in a python discourse thread and I would agree with the sentiment that we should include them in the wheels and tarballs, they are not very large.

I am not sure what needs to change in the setup.py to include the tests.

We should also move away from setup.py to use pyproject.toml + a build backend like meson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants