Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: component_gallery() contains kwargs where none are needed #241

Open
guy-singer opened this issue Jul 30, 2023 · 0 comments
Open

[Bug]: component_gallery() contains kwargs where none are needed #241

guy-singer opened this issue Jul 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@guy-singer
Copy link
Member

What happened?

the component_gallery() contains **kwargs, even though there is no direct benefit to including these. This means that if a user includes an invalid argument, no error is returned, and the user may not be aware that their code did not execute as intended due to the invalid argument. For example, a user may misspell "num_images", and mistakenly believe the function will return the number of images they meant to specify, when in reality the function will effectively ignore the argument.

What did you expect to see?

No response

What version of fastdup were you runnning on?

current version

What version of Python were you running on?

Python 3.10

Operating System

MacOs

Reproduction steps

No response

Relevant log output

No response

Attach a screenshot [Optional]

No response

Contact Details [Optional]

No response

@guy-singer guy-singer added the bug Something isn't working label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant