Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Run 8x8x8 to check the whole pipeline with non 1D files #44

Open
garikoitz opened this issue Jan 23, 2020 · 3 comments
Open

[TEST] Run 8x8x8 to check the whole pipeline with non 1D files #44

garikoitz opened this issue Jan 23, 2020 · 3 comments
Assignees

Comments

@garikoitz
Copy link
Contributor

No description provided.

@garikoitz garikoitz self-assigned this Jan 24, 2020
@garikoitz
Copy link
Contributor Author

@noahbenson , right now if the synthetic json file is not passed the system fails. I started checking popeye but I guess the problem is in all tools. The problem I see with this is that some of the params for solving are coming from the json file, so if we use a real file, we'll need to pass those variables in the prfanalyze-tool-config.json file. I am guessing that we can assume this, but checking with you before doing anything:

  • If there is no json file, it should assume that it is external data, and continue
  • There will be missing configs, so if there is no json file, we'll nee to check that all the minimally required values are being passed to the function or fail (some defaults are not valid)
  • Can external data be any size? (I mean 1D or volume) I think so, but let's discuss.
  • The output files with the results will be the same as the input format, 1D or volume, but following the same naming convention

@noahbenson
Copy link
Collaborator

Hmm, I'm a bit confused:

  • "synthetic json file" is the file output from prfSynth?
  • when is that file not passed? (only when a default config file should be written out?)
  • can you give me some examples of the variables we'd need to add to one of the prfanalyze-tool-config.json file?

@garikoitz
Copy link
Contributor Author

garikoitz commented Jan 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants