Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add custom overlays example to website examples #2215

Open
tordans opened this issue Jul 1, 2023 · 0 comments
Open

[Feat] Add custom overlays example to website examples #2215

tordans opened this issue Jul 1, 2023 · 0 comments
Labels

Comments

@tordans
Copy link
Contributor

tordans commented Jul 1, 2023

Target Use Case

The update guide https://visgl.github.io/react-map-gl/docs/upgrade-guide#module-exports references the custom overlays https://github.com/visgl/react-map-gl/tree/7.0-release/examples/custom-overlay.

However, those are not part of the website examples https://visgl.github.io/react-map-gl/examples/; https://visgl.github.io/react-map-gl/examples/custom-overlay returns a 404.

Proposal

Add the custom overlay example to the website.

It looks like the code for that is https://github.com/visgl/react-map-gl/blob/master/website/src/examples-sidebar.js#L24. And it looks like and MDX file like https://github.com/visgl/react-map-gl/blob/master/website/src/examples/custom-cursor.mdx is needed as well.

@tordans tordans added the feature label Jul 1, 2023
@tordans tordans changed the title [Feat] Add custom overlays to website example examples [Feat] Add custom overlays example to website example examples Jul 1, 2023
@tordans tordans changed the title [Feat] Add custom overlays example to website example examples [Feat] Add custom overlays example to website examples Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant