Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tileset3D support modelMatrix #2543

Open
radoslavirha opened this issue Jul 10, 2023 · 1 comment
Open

Tileset3D support modelMatrix #2543

radoslavirha opened this issue Jul 10, 2023 · 1 comment

Comments

@radoslavirha
Copy link
Contributor

Hi,

would it be possible to implement modelMatrix in Tileset3D?

Described here: visgl/deck.gl#7309 (comment)

Thanks

@ibgreen
Copy link
Collaborator

ibgreen commented Jul 10, 2023

(Updated PR title.)

Yes, it should of course be possible, and we'd certainly consider a PR, however:

  • This affects the traversal part of Tileset3D (traversing the hierarchy and selecting tiles in view based on current viewport(s)).
  • Unfortunately, traversal is the most fragile and hacky part of the current implementation (e.g. a number of glitches become evident when using the new Google 3D tiles)
  • this code is due for a major refactor. (Perhaps basing it the latest traversal implementation in Cesium.)

So

  • fixing modelMatrix in the current implementation does not seem very motivating. It is likely a bit fiddly and would need to be redone after the refactor.
  • fixing it during the refactor makes sense, but so far, no one has signed up for working on the refactored traversal.

Also, adding modelMatrix support to traversal primarily handles the case when then model matrix shifts the view enough that different tiles need to be loaded. It seems to me that modelMatrix still needs to be support by Tile3DLayer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants