Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ic_launcher from Android SDK #326

Open
robderijk opened this issue Jan 16, 2020 · 0 comments
Open

Remove ic_launcher from Android SDK #326

robderijk opened this issue Jan 16, 2020 · 0 comments

Comments

@robderijk
Copy link

robderijk commented Jan 16, 2020

Environment

Please provide the following information about your environment:

  1. OS: Mac
  2. Version: 1.17.0
  3. Device(s): All

Description

The default ic_launcher.png icon is included in the ViroCore Android SDK which causes issues when building an .aab: Modules 'base' and 'feature_augmented_reality' contain entry 'res/mipmap-mdpi-v4/ic_launcher.png' with different content.. It is possible to get this removed from the SDK, I don't think it's of any use for an SDK.

Reproducible Demo

Add the ViroCore Android SDK as a dependency in a dynamic feature module and build the app bundle using ./gradlew bundleRelease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant