Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build with Visual Studio 2022. #1637

Open
namark opened this issue Apr 5, 2022 · 2 comments
Open

Fix the build with Visual Studio 2022. #1637

namark opened this issue Apr 5, 2022 · 2 comments
Labels
stale Issue / PR has not had activity

Comments

@namark
Copy link
Contributor

namark commented Apr 5, 2022

I had to update vcpkg using the bootstrapping option, but ultimately wasn't able to get NVTT port to build, getting internal compiler errors from MSVC (possibly something on their side, that might be fixed in the future). I wasn't able to use the official NVTT port either since it brought some new dependencies with it, that themselves didn't seem to work properly with our setup.

Relevant PRs:
#1606 - Initial fix that worked briefly.
#1611 #1613 - A couple of failed attempts to fix NVTT.
#1616 - Giving up and downgrading the environment.
#1633 - Reverting previous changes as they broke the aarch64 build.

The build worked for a brief period of time after enabling bootstrapping with #1606
https://github.com/vircadia/vircadia/runs/5274016300?check_suite_focus=true (Windows Server 2022, Visual Studio 17 2022)
and that's why the PR was merged, but then it started failing again I'm guessing due to another environment update.

@stale
Copy link

stale bot commented Oct 2, 2022

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Oct 2, 2022
@namark namark removed the stale Issue / PR has not had activity label Oct 2, 2022
@stale
Copy link

stale bot commented Mar 31, 2023

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue / PR has not had activity
Projects
None yet
Development

No branches or pull requests

1 participant