Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not use enums for tree_criterion, parametric_method, selection_criterion? #158

Open
slayoo opened this issue Apr 6, 2017 · 4 comments

Comments

@slayoo
Copy link
Collaborator

slayoo commented Apr 6, 2017

No description provided.

@tvatter
Copy link
Collaborator

tvatter commented Apr 6, 2017

That's a good idea.

The only "con" argument that I see is that it is more cumbersome to write e.g. tree_criterion::tau than just "tau".

@tnagler
Copy link
Collaborator

tnagler commented Apr 6, 2017

Agree. The "pro" argument is that the code expresses more clearly what "tau" is ;)

@tvatter
Copy link
Collaborator

tvatter commented Apr 6, 2017

Definitely, and using enums also prevents the need for error messages, but both pros were kind of obvious, hence the quotes for "con" :)

All in favor say aye.

@tnagler
Copy link
Collaborator

tnagler commented Apr 6, 2017

Let's do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants