Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player instance is not available in ready event #1345

Closed
zyrif opened this issue Jul 15, 2023 · 10 comments
Closed

Player instance is not available in ready event #1345

zyrif opened this issue Jul 15, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@zyrif
Copy link

zyrif commented Jul 15, 2023

Hi,

According to the documentation here, @ready event should pass the player instance in it's callback argument.

In it's code, v-clapper expects to receive the player instance as the argument of the callback of onReady event. However, clappr-core doesn't appear to return the player instance as an argument for this event, as documented here.

As a result, we don't appear to have any way to access the player instance (correct me if I'm wrong).
This issue is reproducible in the StackBlitz demo, where this line prints undefined in the console:

image

Also, the example has an @init event that doesn't appear to fire and is not mentioned in the document. Since this event is no longer available, do we have an alternative way to access the player instance?

@github-actions
Copy link

A stale label has been added to this issue because it has been open 15 days with no activity. To keep this issue open, add a comment within 5 days.

@github-actions github-actions bot added the stale label Jul 31, 2023
@zyrif
Copy link
Author

zyrif commented Jul 31, 2023

Bump

@github-actions github-actions bot removed the stale label Aug 1, 2023
@github-actions
Copy link

A stale label has been added to this issue because it has been open 15 days with no activity. To keep this issue open, add a comment within 5 days.

@github-actions github-actions bot added the stale label Aug 17, 2023
@zyrif
Copy link
Author

zyrif commented Aug 17, 2023 via email

@github-actions github-actions bot removed the stale label Aug 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

A stale label has been added to this issue because it has been open 15 days with no activity. To keep this issue open, add a comment within 5 days.

@github-actions github-actions bot added the stale label Sep 2, 2023
@zyrif
Copy link
Author

zyrif commented Sep 2, 2023 via email

@github-actions github-actions bot removed the stale label Sep 3, 2023
@github-actions
Copy link

A stale label has been added to this issue because it has been open 15 days with no activity. To keep this issue open, add a comment within 5 days.

@github-actions github-actions bot added the stale label Sep 18, 2023
@zyrif
Copy link
Author

zyrif commented Sep 23, 2023

Bump

@github-actions github-actions bot removed the stale label Sep 24, 2023
@github-actions
Copy link

A stale label has been added to this issue because it has been open 15 days with no activity. To keep this issue open, add a comment within 5 days.

@github-actions github-actions bot added the stale label Oct 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2023
@vinayakkulkarni vinayakkulkarni added bug Something isn't working and removed stale labels Oct 16, 2023
@vinayakkulkarni
Copy link
Owner

Player instance should be available in the init event, don't use the ready event.

Done in v3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants