TooManyArguments false positive

[edsrzf]

https://psalm.dev/r/297ffd1c85

This seems to be an interaction between:

• Parent class constructor that calls a private method - making the init method protected or higher fixes the error
• Parent class that has a magic __call method - removing the magic method fixes the error
• Property initialization analysis for the child class - removing the child class fixes the error

A bit of debugging shows that analysis is getting into MissingMethodCallHandler, and the reason for the TooManyArguments error is that this call is erroneously being transformed into a call to __call. I'm guessing that it's trying to find the private method in the context of the child class.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/297ffd1c85

<?php

class Base
{
    protected int $i;
    
    public function __construct()
    {
        $this->init(1);
    }
    
    private function init(int $value): void
    {
        $this->i = $value;
    }
    
    public function __call()
    {
    }
}

class Child extends Base
{
}

Psalm output (using commit 16b24bd):

ERROR: TooManyArguments - 9:16 - Too many arguments for method Base::init - saw 1