Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: phpunit should fail on deprecated notices #10957

Open
kkmuffme opened this issue May 5, 2024 · 1 comment · May be fixed by #10958
Open

CI: phpunit should fail on deprecated notices #10957

kkmuffme opened this issue May 5, 2024 · 1 comment · May be fixed by #10958
Labels

Comments

@kkmuffme
Copy link
Contributor

kkmuffme commented May 5, 2024

If psalm itself triggers PHP notices in CI these aren't reported and the tests don't fail
e.g. #10950 that issue would have been caught 3 years ago and I wonder how nobody has encountered that notice when running CI locally with a stricter error handler :)

Copy link

Hey @kkmuffme, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants