Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor & Code Formatting Config #3

Closed
5 tasks done
joshuapease opened this issue May 9, 2024 · 0 comments
Closed
5 tasks done

Editor & Code Formatting Config #3

joshuapease opened this issue May 9, 2024 · 0 comments
Assignees
@joshuapease

Comments

@joshuapease
Copy link
Contributor

joshuapease commented May 9, 2024 •
edited

  • Husky or vanilla Git hooks
  • PHPStan
  • PHP Formatting
  • Prettier
  • eslint
@joshuapease joshuapease self-assigned this May 20, 2024
joshuapease added a commit that referenced this issue May 21, 2024
@joshuapease
[#3] Add prettier and .editorconfig
704d4dc
joshuapease added a commit that referenced this issue May 21, 2024
@joshuapease
[#3] Run prettier . --write
9ceea68
joshuapease added a commit that referenced this issue May 21, 2024
@joshuapease
[#3] Install & configure eslint
e64cac9
joshuapease added a commit that referenced this issue May 21, 2024
@joshuapease
[#3] Install PHP ECS and run fix
85ffb31
joshuapease added a commit that referenced this issue May 21, 2024
@joshuapease
[#3] Install and configure PHPStan
80d41d0
joshuapease added a commit that referenced this issue May 21, 2024
@joshuapease
[#3] Install Husky
56b978d 
- npm install --save-dev husky
- npx husky init

Add DDEV configs to ensure Husky is connected to the user & DDEV's Git processes
joshuapease added a commit that referenced this issue May 21, 2024
@joshuapease
[#3] Install & configure lint-staged
bdfc227 
This runs our linters & formatters on just the files that have changed.
@joshuapease joshuapease mentioned this issue May 22, 2024
Merged
joshuapease added a commit that referenced this issue May 22, 2024
@joshuapease
[#3] Install & configure lint-staged
7f91046 
This runs our linters & formatters on just the files that have changed.
joshuapease added a commit that referenced this issue May 22, 2024
@joshuapease
[#3] eslint disallow console.log
aac6b96
joshuapease added a commit that referenced this issue May 22, 2024
@joshuapease
[#3] Remove npm run prepare from ddev.
11f2293 
Apparently `prepare` runs after each npm install.

https://typicode.github.io/husky/how-to.html#manual-setup
joshuapease added a commit that referenced this issue May 22, 2024
@joshuapease
[#3] PR Feedback
8af39d0
joshuapease added a commit that referenced this issue May 22, 2024
@joshuapease
[#3] Automatic code formatting & linting (#12)
06e90d3 
* [#3] Add prettier and .editorconfig

* [#3] Run `prettier . --write`

* [#3] Install & configure eslint

* [#3] Install PHP ECS and run fix

* [#3] Install and configure PHPStan

* [#3] Install Husky

- npm install --save-dev husky
- npx husky init

Add DDEV configs to ensure Husky is connected to the user & DDEV's Git processes

* [#3] Install & configure lint-staged

This runs our linters & formatters on just the files that have changed.

* [#3] eslint disallow console.log

* [#3] Remove npm run prepare from ddev.

Apparently `prepare` runs after each npm install.

https://typicode.github.io/husky/how-to.html#manual-setup

* [#3] PR Feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuapease joshuapease

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuapease