Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are wrong #533

Open
mayeaux opened this issue Oct 12, 2021 · 1 comment
Open

Docs are wrong #533

mayeaux opened this issue Oct 12, 2021 · 1 comment

Comments

@mayeaux
Copy link

mayeaux commented Oct 12, 2021

Screen Shot 2021-10-12 at 9 30 14 PM

player.one('adended', function() {

        player.ads.endLinearAdMode();
      });

Interesting, because:
Screen Shot 2021-10-12 at 9 32 03 PM

Says the event is adend (which it is)

Guess this means the docs are wrong? Also, why can't I star this repo? Thanks

@gkatsev
Copy link
Member

gkatsev commented Oct 12, 2021

If you have an adblocker enabled, it may interfere with github and this repo.

Also, the adend event fires when endLinearAdMode() is called, where-as the example uses adended to call the method. While similarly named, they are separate events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants