Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional argument to the BoundingBoxAnnotator with dict of classes labels #95

Open
rominf opened this issue Sep 2, 2019 · 1 comment

Comments

@rominf
Copy link

rominf commented Sep 2, 2019

I've added a simple implementation MxnetObjectDetector to my fork of videoflow-contrib (https://github.com/rominf/videoflow-contrib/commit/ec843363f7f33947dbd12b0cdf57b765f2013132).

I have classes labels in a MxnetObjectDetector._mxnet_model.classes as a list and want to pass them to the BoundingBoxAnnotator. I think that creating the file with class labels and then reading it is slow and inconvenient.

So, I propose to add class_labels_dict = None to the BoundingBoxAnnotator.__init__.

What do you think? If you want, I can do PR.

@jadielam
Copy link
Collaborator

jadielam commented Sep 3, 2019

It makes sense. Just be sure to give preference to one over the other when both class_labels_dict and class_labels_path are provided (and to document that case), and to throw an error if none of the two is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants