Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - Code splitting / modularization #2175

Open
michaelcunningham19 opened this issue Mar 13, 2019 · 3 comments
Open

Proposal - Code splitting / modularization #2175

michaelcunningham19 opened this issue Mar 13, 2019 · 3 comments
Labels
Enhancement Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix.

Comments

@michaelcunningham19
Copy link
Member

Is your feature request related to a problem? Please describe.

No issue in particular, other than not easily being able to easily omit certain pieces of functionality.
We offer a 'light' build that currently removes:

  • alt-audio support
  • subtitles support
  • EME support

However depending on the combination of features desired (e.g. if someone wants EME support but not subtitles or alt-audio support) they're either forced to build from source with local code modifications or use the main fully-featured build.

Describe the solution you'd like

Perhaps a 'plugin' system - where core functionality stays in place and utilizes a set of provided plugins.

Further design details TBD

Describe alternatives you've considered

None. Are there any other alternative approaches to tackle this?

Additional context

We should still always provide the main and light builds for the folks that want them.

It would be really slick if we also have the ability to easily build from source with a selectable list of features, so no local code modifications are needed.

As well, we could come up with some other pre-built options to offer alongside the main and light builds.

@michaelcunningham19 michaelcunningham19 changed the title 1.x - Code splitting / modularization Proposal - Code splitting / modularization Mar 27, 2019
@Korilakkuma
Copy link
Contributor

@michaelcunningham19

#2274 (comment) is a work in progress.
Please review this PR when you're available. I'm sorry for your inconvenience.

@robwalch
Copy link
Collaborator

I agree this is needed, as the "light" build is really not suited for the most common use case where everything except for EME is needed. IMO the published library should not solve every possible use case. We need to continue offering updates for the UMD packages available today, but more modular approaches could be solved by those integrating the player using es6 exports. See #2910.

@robwalch robwalch added Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. and removed Waiting for author Need info labels Sep 1, 2023
@robwalch
Copy link
Collaborator

robwalch commented Apr 4, 2024

Related conversation #6307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix.
Projects
None yet
Development

No branches or pull requests

3 participants