Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canAutoPlay.video() opens a fullscreen overlay on iPhone #43

Open
fabianwohlfart opened this issue Jul 14, 2021 · 2 comments
Open

canAutoPlay.video() opens a fullscreen overlay on iPhone #43

fabianwohlfart opened this issue Jul 14, 2021 · 2 comments

Comments

@fabianwohlfart
Copy link

Hi,
on iOS 14.2 the canAutoPlay.video() opens a fullscreen overlay of the test with 0 seconds.
Can we prevent this?

@gkatsev
Copy link
Member

gkatsev commented Jul 14, 2021

That probably makes sense since the default is inline:false, https://github.com/video-dev/can-autoplay/blob/master/lib/index.js#L8
The quick fix is for you to pass inline: true to .video().

canAutoplay.video({
  inline: true
});

I wonder whether we should default inline to true.

@mayeaux
Copy link

mayeaux commented Jan 6, 2022

Definitely set inline as true by default, otherwise it's broken on iOS, just ran into this in some code that was in production and it sucked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants