Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button for the unsplash wallpaper #317

Open
baozidai opened this issue Mar 4, 2024 · 8 comments
Open

Save button for the unsplash wallpaper #317

baozidai opened this issue Mar 4, 2024 · 8 comments
Labels
enhancement New feature or request Planned This will be done in a future update

Comments

@baozidai
Copy link
Contributor

baozidai commented Mar 4, 2024

Is your feature request related to a problem? Please describe.
When I get rolled a nice image from unsplash, I want to save it, but I can't found it :(
Now I can only get to the site of the photogragher, but can't find the image.

Describe the solution you'd like
Add a button for save current unsplash image to local computer. It can be a low priority feature maybe.

@rajarshikhatua100
Copy link

just tap the name of the wallpaper in the bottom left corner it will redirect you to the unsplash website and you can download it from there

@baozidai
Copy link
Contributor Author

baozidai commented Mar 5, 2024

Don't close this issue. I found a localisation problem.
In zh_CN, there is no "photo"-like word to indicate that you can access the photo. Left corner shows "拍摄者 " which means "photographer is " but in en_us shows "Photo by " which "Photo" notice you can click it.
I hope you can understand the above misunderstanding. I will fix the translation soon.

@baozidai
Copy link
Contributor Author

baozidai commented Mar 7, 2024

What I want it's "图片 由 !someone! 拍摄". In this way it just like "Photo by !someone!" in English which "Photo" mapping to "图片" then it click-able. But I can not make it by only editing the localization because of the tail "拍摄".

Honestly,it is OK there is not "拍摄", but it will be strange in Chinese.

@victrme
Copy link
Owner

victrme commented Mar 7, 2024

I see. There is a similar issue with the weather forecast in Russian, which means we'll have to improve the way full sentences are translated.

It shouldn't be too complex, however I've started a lot of other things I need to finish first, so that might take some time.

I will @ you in this issue once the new translation method is available !

@victrme
Copy link
Owner

victrme commented Mar 21, 2024

Hello @baozidai, improved credit translation is here! Is this translation correct ?

image

@baozidai
Copy link
Contributor Author

@victrme
Absolutely right! Thanks for your efforts!

@victrme victrme closed this as completed Mar 21, 2024
@Gitoffthelawn
Copy link
Contributor

I keep coming back to this feature request, and I just wanted to mention I think it has potential.

@rajarshikhatua100 is correct: one can click on the link and download the background image from the source. But that's an extra step (and more MBs for people on slow/metered connections).

My purpose of posting is just to mention that I think a "save" button for the background may be worthwhile. Another possibility could be to add right-click functionality (on the link that opens the background's source page) that quickly downloads the image.

In any case, I don't think it's a big priority, but this keeps coming up in my feed because I keep thinking about it and wanted to mention my thoughts... and now I have. 😄

@victrme
Copy link
Owner

victrme commented May 3, 2024

I agree it does save a few clicks and page loads! I think we can add a small download icon that appears when you hover your mouse over the credits.

We also have some ideas regarding right clicks, so that might also be added in the future!

@victrme victrme reopened this May 3, 2024
@victrme victrme added enhancement New feature or request Planned This will be done in a future update labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Planned This will be done in a future update
Projects
None yet
Development

No branches or pull requests

4 participants