Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the ESC key binding. #316

Open
gynet opened this issue Mar 2, 2024 · 5 comments
Open

Disable the ESC key binding. #316

gynet opened this issue Mar 2, 2024 · 5 comments
Labels
enhancement New feature or request Planned This will be done in a future update

Comments

@gynet
Copy link

gynet commented Mar 2, 2024

Is there any way to disable the ESC binding? Context: I am a Vim user with a browser extension enabled.

@victrme
Copy link
Owner

victrme commented Mar 3, 2024

Hi @gynet, right now there is no way to disable the keybinding, but we'll focus on keybinding soon enough.

How do you use vim and bonjourr at the same time ? Are you using online.bonjourr.fr, or is there a way to have both extension at the same time ?

@victrme victrme added enhancement New feature or request Planned This will be done in a future update labels Mar 3, 2024
@gynet
Copy link
Author

gynet commented Mar 3, 2024

I am using Floorp, surfingkeys + new tab override

@victrme
Copy link
Owner

victrme commented Mar 6, 2024

I see, pretty cool combo. With new tab override, what URL did you set ?

Is it https://online.bonjourr.fr or moz-extension://60b72b62-6127-432f-8ce4-0fc5d5f92f10/index.html ?

If you used the extension, using surfingkeys on top of it is not possible since extension have to be isolated from each other for security reasons...

Using https://online.bonjourr.fr, I don't see any issue with the 'ESC' binding. I don't know anything about vim keybindings so I might be wrong.

@gynet
Copy link
Author

gynet commented Mar 6, 2024

@victrme

  • using https://online.bonjourr.fr
  • I added many links and sometimes use surfingkeys to select one of them using the F key. I often press ESC twice. In regular Vim environment, it does not have any side effects but, in this case, it will pop the config settings.

@victrme
Copy link
Owner

victrme commented Mar 8, 2024

OK, that's not so bad, I thought it was preventing you from accessing something !

As I mentioned in my first comment, we'll add keybindings and a way to configure them. I said "soon enough" but it is actually medium/low priority for now, so no false promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Planned This will be done in a future update
Projects
None yet
Development

No branches or pull requests

2 participants