Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration of repo to VertxJUnit4ClassRunner #2

Open
johnoliver opened this issue May 3, 2013 · 0 comments
Open

Add configuration of repo to VertxJUnit4ClassRunner #2

johnoliver opened this issue May 3, 2013 · 0 comments

Comments

@johnoliver
Copy link

Since the recent domain change of github to github.io for the module repository, this has broken almost all of our tests, and currently vertx-junit-annotations does not offer any way to configure the repository. This is a very major issue for us as we are using it in a commercial environment and is causing us to ignore tests in order to prevent it from blocking our release.

Unfortunately since HEAD appears to have moved on since to support vertx 2 adding this to the current HEAD will not be of any use to us for a while. I have made a branch that applies the fix to the last release. Is it possible to get this released from a branch as a back ported fix to support vertx 1.x? I believe going forward it would also be a reasonable configuration option to have even in the vertx 2 version.

The branch is at:

https://github.com/johnoliver/vertx-junit-annotations/tree/repo-fix-backport

and the specific patch is:

johnoliver@c0e8d00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant