You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for your amazing project! I added it yesterday to a couple of my projects and it works very well 馃憦馃徎
One thing that I stumbled upon was using the Git tag created by versionize as Docker image tag and the tag's v prefix. For example, let's assume calling dotnet versionize creates a new Git tag v3.0.0. Now when creating a Docker image for this release via GitHub Actions, I have to shorten the Git tag like this so that my final image is tagged mu88/raspifancontroller:3.0.0 instead of mu88/raspifancontroller:v3.0.0 (which would happen when using ${{ github.ref_name }}):
Since I had to insert this snippet into each of my Release pipeline, it would be cool if I could instruct versionize to create a Git tag without the v prefix (i. e. 3.0.0 instead of v3.0.0).
The text was updated successfully, but these errors were encountered:
I have looked around a bit in the code and two ideas came to my mind:
Introduce public bool OmitTagPrexifx { get; set } in VersionizeOptions (which just signals to omit the version prefix v and is false by default to not break with previous behavior) and check for this property in WorkingCopy.Versionize. This is (probably/hopefully 馃馃徎) easy to implement, but further complicates the logic of WorkingCopy.Versionize.
Hook into the string formatting, which is more work and probably an overkill:
Introduce both public string VersionString { get; set } in VersionizeOptions and extension method public static string ToVersionizeString(this NuGet.Versioning.SemanticVersion version) which consumes VersionizeOptions.VersionString.
Implement a custom IFormatProvider and pass it here.
Hi 馃憢馃徎
First of all, thank you for your amazing project! I added it yesterday to a couple of my projects and it works very well 馃憦馃徎
One thing that I stumbled upon was using the Git tag created by versionize as Docker image tag and the tag's
v
prefix. For example, let's assume callingdotnet versionize
creates a new Git tagv3.0.0
. Now when creating a Docker image for this release via GitHub Actions, I have to shorten the Git tag like this so that my final image is taggedmu88/raspifancontroller:3.0.0
instead ofmu88/raspifancontroller:v3.0.0
(which would happen when using${{ github.ref_name }}
):Since I had to insert this snippet into each of my Release pipeline, it would be cool if I could instruct versionize to create a Git tag without the
v
prefix (i. e.3.0.0
instead ofv3.0.0
).The text was updated successfully, but these errors were encountered: