Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL: ignore some folders #966

Open
ibc opened this issue Dec 5, 2022 · 1 comment
Open

CodeQL: ignore some folders #966

ibc opened this issue Dec 5, 2022 · 1 comment

Comments

@ibc
Copy link
Member

ibc commented Dec 5, 2022

Must tell .github/workflows/codeql.yml to ignore these folders:

art
doc
rust/benches
rust/examples
rust/examples-frontend
worker/deps
worker/subprojects
worker/scripts
worker/fuzzer
worker/out

There is a paths-ignore field in CodeQL that is just valid for interpreted languages (Python, JS, TS), however it doesn't work for compiled languages in which complex stuff must be done.

I found this but I don't understand it plus it seems to be outdated for CodeQL v1 CI actions.


UPDATE: As discussed here https://github.com/orgs/community/discussions/42654, .gitattributes is no longer valid to tell Code Search which folders to include/exclude, so:

This is not currently possible. If you're in the new Code Search beta you can exclude paths from your search by using a regex like this: NOT path:/worker\/deps/

For now I'll remove .gitattributes from mediasoup repo since it has zero value now.

@ibc ibc added the enhancement label Dec 5, 2022
@versatica versatica deleted a comment from chennasi Dec 6, 2022
@versatica versatica locked as off-topic and limited conversation to collaborators Dec 7, 2022
@ibc
Copy link
Member Author

ibc commented Jan 5, 2023

As discussed here https://github.com/orgs/community/discussions/42654, .gitattributes is no longer valid to tell Code Search which folders to include/exclude, so:

This is not currently possible. If you're in the new Code Search beta you can exclude paths from your search by using a regex like this: NOT path:/worker\/deps/

For now I'll remove .gitattributes from mediasoup repo since it has zero value now.

@ibc ibc added this to the v3 updates milestone Jan 5, 2023
@versatica versatica deleted a comment from chennasi Jan 5, 2023
@versatica versatica deleted a comment from nazar-pc Jan 5, 2023
@versatica versatica unlocked this conversation Jan 5, 2023
sarumjanuch pushed a commit to sarumjanuch/mediasoup that referenced this issue Jan 9, 2023
piranna pushed a commit to dyte-in/mediasoup that referenced this issue Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant