Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: turbo/examples /with-svelte/ - Remove deprecated prettierrc option: pluginSearchDirs #8068

Open
1 task done
menuscreen opened this issue May 2, 2024 · 1 comment · May be fixed by #8092
Open
1 task done

Minor: turbo/examples /with-svelte/ - Remove deprecated prettierrc option: pluginSearchDirs #8068

menuscreen opened this issue May 2, 2024 · 1 comment · May be fixed by #8092
Labels
area: examples Improvements or additions to examples good first issue Good for newcomers kind: bug Something isn't working owned-by: turborepo

Comments

@menuscreen
Copy link

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://github.com/vercel/turbo/tree/main/examples/with-svelte

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Linux

Which canary version will you have in your reproduction?

n/a

Describe the Bug

deprecated option prettierrc option pluginSearchDirs

Expected Behavior

Solution:

paths: apps/web/.prettierrc and apps/docs/.prettierrc

{
	"useTabs": true,
	"singleQuote": true,
	"trailingComma": "none",
	"printWidth": 100,
	"plugins": ["prettier-plugin-svelte"],
	// "pluginSearchDirs": ["."], // Remove me
	"overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }]
}

To Reproduce

npx create-turbo@latest -e with-svelte

pnpm i

pnpm format

./apps/web/.prettierrc: "pluginSearchDirs": ["."],
./apps/docs/.prettierrc:        "pluginSearchDirs": ["."],
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:    "pluginSearchDirs": ["."], // should be removed in v3
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:- "pluginSearchDirs": ["."],
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:-   Prettier no longer searches for plugins in the directory automatically, you need to tell Prettier specifically which plugins to use. This means you need to add `"plugins": ["prettier-plugin-svelte"]` to your config if you haven't already. Also remove the deprecated option `pluginSearchDirs`.
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:    pluginSearchDirs: false,
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.15/node_modules/prettier-plugin-svelte/README.md:    "pluginSearchDirs": ["."], // should be removed in v3
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.15/node_modules/prettier-plugin-svelte/README.md:- "pluginSearchDirs": ["."],
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.15/node_modules/prettier-plugin-svelte/README.md:-   Prettier no longer searches for plugins in the directory automatically, you need to tell Prettier specifically which plugins to use. This means you need to add `"plugins": ["prettier-plugin-svelte"]` to your config if you haven't already. Also remove the deprecated option `pluginSearchDirs`.
./node_modules/.pnpm/prettier-plugin-svelte@3.2.3_prettier@3.2.5_svelte@4.2.15/node_modules/prettier-plugin-svelte/README.md:    pluginSearchDirs: false,
./node_modules/.pnpm/prettier-plugin-svelte@3.2.2_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:    "pluginSearchDirs": ["."], // should be removed in v3
./node_modules/.pnpm/prettier-plugin-svelte@3.2.2_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:- "pluginSearchDirs": ["."],
./node_modules/.pnpm/prettier-plugin-svelte@3.2.2_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:-   Prettier no longer searches for plugins in the directory automatically, you need to tell Prettier specifically which plugins to use. This means you need to add `"plugins": ["prettier-plugin-svelte"]` to your config if you haven't already. Also remove the deprecated option `pluginSearchDirs`.
./node_modules/.pnpm/prettier-plugin-svelte@3.2.2_prettier@3.2.5_svelte@4.2.12/node_modules/prettier-plugin-svelte/README.md:    pluginSearchDirs: false,

Additional context

I performed pnpm upgrade in each dir containing package.json before running pnpm format from the root dir.
@menuscreen menuscreen added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels May 2, 2024
@anthonyshew
Copy link
Contributor

Happy to take a PR for this if I don't get around to it first!

@mehulkar mehulkar added good first issue Good for newcomers area: examples Improvements or additions to examples and removed needs: triage New issues get this label. Remove it after triage labels May 2, 2024
@fucksophie fucksophie linked a pull request May 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: examples Improvements or additions to examples good first issue Good for newcomers kind: bug Something isn't working owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(examples): remove deprecated prettierrc option fucksophie/turbo
3 participants
@mehulkar @anthonyshew @menuscreen