Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PL, GL after filter or primitive #147

Open
zeeev opened this issue Apr 14, 2016 · 6 comments
Open

Cleanup PL, GL after filter or primitive #147

zeeev opened this issue Apr 14, 2016 · 6 comments

Comments

@zeeev
Copy link
Collaborator

zeeev commented Apr 14, 2016

@chapmanb @NeillGibson @ekg

I've opened this as issue:
bcbio/bcbio-nextgen#1334 (comment)

The cleanup will need to be implemented in each tool as there is no way to know which PLs to remove without the original VCF entry? Is that the case?

--Zev

@chapmanb
Copy link
Contributor

Zev and Erik;
Thanks for looking at this. It sounded from the other comments like Erik already had code for this but it wasn't being used currently. Is that right? From my perspective it could either happen in the tools themselves at the time of splitting or as a post processing step by checking if the PLs (and other attributes) match the number of alleles and removing attributes if not. I'm not sure which is easier/closer to already implemented, but happy to go with that. Thanks again for thinking about this.

@NeillGibson
Copy link

@zeeev Thank you for looking at this. I agree with Brad. Whatever option is easier would be fine for me. Either a new option in vcfallelicprimitives to drop the attributes for the inconsistent records or a post processing tool that would fix the inconsistent records. Thanks again.

@NeillGibson
Copy link

Hi @zeeev . Is there any progress on this issue? We keep running into this issue and find it difficult to filter out all variant cases that have this inconsistency. Thanks again for looking at this issue.

@JorisBenschop
Copy link

I understand that this issue is acknowledged as 'high priority' but there seems to have been very little activity since april. Could you please either reclassify this priority or (preferentially) give some notion on when this will be addressed. The current implementation gives corrupted vcf output which I think we should take very seriously.

@zeeev
Copy link
Collaborator Author

zeeev commented Aug 3, 2016

@NeillGibson @JorisBenschop You're correct. I haven't had time to work on it. @ekg can PRIMITIVE strip out the unused GT fields and is that something you can do? I've looked through the code and had trouble following. There isn't enough info for VCFFILTER to fix the problem, otherwise I'd do it.

@averagehat
Copy link

Is this fixed? Does the method proposed in #156 (comment) work correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants