Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with StrictMode #1194

Closed
Akshaya-009 opened this issue Dec 1, 2022 · 4 comments · Fixed by #1324
Closed

Compatibility with StrictMode #1194

Akshaya-009 opened this issue Dec 1, 2022 · 4 comments · Fixed by #1324
Assignees
Labels
Area: Core Affects the uniforms package Type: Bug Bug reports and their fixes
Milestone

Comments

@Akshaya-009
Copy link

After updating uniforms and uniforms-unstyled to version 3.10.1, unable to see the values in the input field.

Please check the issue and update us on the same.

Attaching Codesandbox link for the reference:

Click to open codesanbox

@wadamek65
Copy link
Contributor

Hi @Akshaya-009 , thank you for the issue report.

The issue you are seeing is not caused by uniforms@3.10.1 update directly, but rather by the version of react being 18. The issue seems to go away if you remove StrictMode from the application, so there may be some idempotency problem within core uniforms logic. We will investigate this further and try to resolve it, but depending on the outcome, the fix may be too complex and may have to be postponed to uniforms@4. We will keep you updated on this issue.

@wadamek65 wadamek65 self-assigned this Dec 1, 2022
@wadamek65 wadamek65 added Type: Bug Bug reports and their fixes Area: Core Affects the uniforms package labels Dec 1, 2022
@wadamek65 wadamek65 added this to the v4.0 milestone Dec 1, 2022
@sprasad02
Copy link

@wadamek65 Removing StrictMode works. Until the fix is released can this be added to the doc so that it might be helpful to other devs upgrading to React 18?

@Akshaya-009
Copy link
Author

Thank you for the reply @wadamek65 and @sprasad02. Please update once it is fixed in version 4.

@maslennikov
Copy link

I confirm, with Nextjs 13 and strict mode enabled fields don't get updated when typing (although onChange callbacks trigger and model gets updated with setstate properly). Solution from #1289 doesn't work for me. Had to disable strict mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Affects the uniforms package Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants