Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Adopt vtest for varnishtest #3983

Open
1 of 7 tasks
dridi opened this issue Sep 18, 2023 · 2 comments
Open
1 of 7 tasks

build: Adopt vtest for varnishtest #3983

dridi opened this issue Sep 18, 2023 · 2 comments

Comments

@dridi
Copy link
Member

dridi commented Sep 18, 2023

Here is the check list of steps to get there:

  • Make the check list
  • Register custom commands in vtest
    This would give us the ability to retain vtc_varnish, vtc_logexp etc here, remove them in vtest.
  • Split vtest into a library and a program
    Some command line options like -i only make sense here, remove them in vtest.
  • Add tooling to bundle vtest as a git submodule
    • Add automation to vendor vtest when we branch out
      In trunk we can track vtest master as a submodule, we replace it with a static copy when we create x.y branches.
    • Add automation to apply vtest patch to x.y branches
      The goal is facilitate cherry-picks from the vtest tree to the varnish-cache sub-tree
  • Add a vtest submodule
  • Make varnishtest use libvtest.a
    And keep varnishtest with varnish-specific command line options.

Then we can support TLS in vtest.

@nigoroll
Copy link
Member

Prior work: #2838

@nigoroll
Copy link
Member

Updated plan from VDD:

  • Re-start the vtest repo as vtest2, preserving the git history from varnish-cache
  • Change order of TODOs, start with submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants