Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varnish license #3980

Open
uhliarik opened this issue Sep 11, 2023 · 0 comments
Open

Varnish license #3980

uhliarik opened this issue Sep 11, 2023 · 0 comments

Comments

@uhliarik
Copy link

Expected Behavior

Files should have correct license text.

Current Behavior

As a part of https://docs.fedoraproject.org/en-US/legal/update-existing-packages/ , I'm reviewing license texts in source files in varnish.

In LICENCE file from varnish source file tarball, I can read that varnish is distributed under BSD-2-Clause license. When I tried to verify it, I ran licensecheck on those source files and I found some discontinuities:

These files have BSD-2-Clause-FreeBSD instead of BSD-2-Clause:

./bin/varnishtest/teken.c: BSD 2-clause FreeBSD License BSD 2-Clause License
./bin/varnishtest/teken.h: BSD 2-clause FreeBSD License BSD 2-Clause License
./bin/varnishtest/teken_scs.h: BSD 2-clause FreeBSD License BSD 2-Clause License
./bin/varnishtest/teken_subr.h: BSD 2-clause FreeBSD License BSD 2-Clause License
./bin/varnishtest/teken_subr_compat.h: BSD 2-clause FreeBSD License BSD 2-Clause License
./include/vsb.h: BSD 2-clause FreeBSD License
./include/vtree.h: BSD 2-clause FreeBSD License BSD 2-Clause License
./include/vend.h: BSD 2-clause FreeBSD License BSD 2-Clause License
./lib/libvarnish/vpf.c: BSD 2-clause FreeBSD License BSD 2-Clause License
./lib/libvarnish/vsb.c: BSD 2-clause FreeBSD License

Files in /lib/libvgz/ should have ZLib license according to /lib/libvgz/README

These files are looking like BSD-3-Clause clause:

./include/vpf.h: BSD 3-Clause License BSD 2-Clause License --- It has BSD-3-Clause identifier, but the text looks like BSD-2-Clause
./include/vqueue.h: BSD 3-Clause License - it is indeed BSD-3-Clause clause
./lib/libvarnishapi/daemon.c: BSD 3-Clause License --- It has BSD-3-Clause identifier, but after points 1. and 2., point 3. is missing and then there is point 4. (typo???)

Following files have Public domain license text in the header of file:

./bin/varnishncsa/b64.c: No copyright Public domain
./include/tbl/vhp_huffman.h: No copyright Public domain
./include/tbl/vhp_static.h: No copyright Public domain
./include/miniobj.h: No copyright Public domain
./vmod/vmod_blob_tbl_encodings.h: No copyright Public domain

Possible Solution

No response

Steps to Reproduce (for bugs)

No response

Context

https://docs.fedoraproject.org/en-US/legal/update-existing-packages/

Varnish Cache version

varnish 7.3.0

Operating system

Fedora

Source of binary packages used (if any)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant