Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESI onerror="abort" handling for OC_F_FAILED #3939

Open
nigoroll opened this issue Jun 12, 2023 · 1 comment
Open

ESI onerror="abort" handling for OC_F_FAILED #3939

nigoroll opened this issue Jun 12, 2023 · 1 comment

Comments

@nigoroll
Copy link
Member

noticed en passant : We should probably also abort for this case

if (req->objcore->flags & OC_F_FAILED) {
/* No way of signalling errors in the middle of
the ESI body. Omit this ESI fragment. */
return;
}

@bsdphk
Copy link
Contributor

bsdphk commented Jun 19, 2023

Noted as part of discussion: ESI spec says

»If an ESI Processor can fetch neither the src nor the alt, it returns a HTTP status code greater than 400 with an error message, unless the onerror attribute is present.«

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants