Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cooler version difference in parameters #186

Open
NMaziak opened this issue Apr 1, 2024 · 2 comments
Open

cooler version difference in parameters #186

NMaziak opened this issue Apr 1, 2024 · 2 comments

Comments

@NMaziak
Copy link

NMaziak commented Apr 1, 2024

Hello,

When running fanc to-cooler I got different results based on the cooler version as discussed here. I was wondering if the filtering could be changed to fit the previous version, since it does seem to be more aggressive after the new additions of mad_max, min_nnz, and min_count.

Thanks for all the help,
Noura

@kaukrise
Copy link
Collaborator

kaukrise commented Apr 8, 2024

Hi Noura,

I have added the parameters you mentioned to to-cooler.

--mad-max MAD_MAX     Cooler balancing setting for bin filtering. Please see Cooler docs for details. Default is 5.
--min-nnz MIN_NNZ     Cooler balancing setting for bin filtering. Please see Cooler docs for details. Default is 10.
--min-count MIN_COUNT
                        Cooler balancing setting for bin filtering. Please see Cooler docs for details. Default is 0.

Could you please test it? You'll need to change the defaults to what they were before the version upgrade.

fanc-0.9.29b1.tar.gz

Best,
Kai

@NMaziak
Copy link
Author

NMaziak commented Apr 12, 2024

Hi Kai,

Amazing, will test it out over the weekend and let you know! I was wondering if the parameter for increasing the amount of iterations could also be included?

Best,
Noura

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants