Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build fail with Xcode 11.3 #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Build fail with Xcode 11.3 #83

wants to merge 2 commits into from

Conversation

hb2708
Copy link

@hb2708 hb2708 commented Jan 16, 2020

This fixes #82

Open in Xcode 11.3 and pod update AudioKit which updates to 4.9.3
Which has a fix for Module compiled with Swift 5.0.1 cannot be imported by the Swift 5.1.3 compiler
Refer AudioKit/AudioKit#1940 for fix

@hb2708
Open in Xcode 11.3 and Updating local specs repositories
c73d8dd 
CocoaPods 1.9.0.beta.2 is available.
To update use: `sudo gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.9.0.beta.2

Analyzing dependencies
Downloading dependencies
Generating Pods project
Integrating client project
Pod installation complete! There are 8 dependencies from the Podfile and 13 total pods installed. which updates to 4.9.3
Which has a fix for Module compiled with Swift 5.0.1 cannot be imported by the Swift 5.1.3 compiler
Refer AudioKit/AudioKit#1940 for fix
@hb2708 hb2708 changed the title Open in Xcode 11.3 and Updating local specs repositories Fix Build fail with Xcode 11.3 Jan 16, 2020
@hb2708 hb2708 force-pushed the master branch 6 times, most recently from e56cdc4 to d403282 Compare January 16, 2020 15:44
@hb2708
Trying to set the xcode developer dir
a73c8bb 
xcodeDeveloperDir: '/Applications/Xcode_11.2.1.app/Contents/Developer'
@hb2708
Copy link
Author

hb2708 commented Jan 16, 2020 •
edited

@vanshg
I have to comment the xcodeVersion in the yml

Coz was facing error with the version and was not able to set directly to xcodeVersion: '11.2.1'
so using xcodeDeveloperDir: '/Applications/Xcode_11.2.1.app/Contents/Developer'

Never used the azure pipeline before
but managed to do above by referring
Pipeline macos doc and Doc for Xcode task

Please take look at changes

@hb2708 hb2708 requested a review from vanshg January 17, 2020 02:21
@hb2708 hb2708 mentioned this pull request Feb 14, 2020
Open
@vanshg
Copy link
Owner

vanshg commented Feb 14, 2020

I actually have made some updates as of last month. I need to push them still. It involves switching to Swift Package Manager and moving away from the xcworkspace format, which should allow compilation. I'll get that pushed soon.

That will probably invalidate this PR

@vanshg
Copy link
Owner

vanshg commented Feb 16, 2020

@hb2708 Are you able to have some more success with this branch? https://github.com/vanshg/MacAssistant/tree/SwiftPM

@hb2708
Copy link
Author

hb2708 commented Feb 19, 2020

@vanshg Tried to run but getting some build errors

@vanshg
Copy link
Owner

vanshg commented Feb 19, 2020

With what error?

@hb2708
Copy link
Author

hb2708 commented Feb 19, 2020 •
edited

So my xcode Version is 11.3.1 (11C504)

Is in file Assistant.swift
this needs to be removed that i have already removed locally.
try streamCall.sendMessage(request).map(<#T##callback: (Void) -> (NewValue)##(Void) -> (NewValue)#>)

lazy var service: AssistantServiceClient = AssistantServiceClient(address: ASSISTANT_API_ENDPOINT, secure: true)
Extra argument 'secure' in call coz the constructor has changes the signature.

service.metadata = try! Metadata(["authorization": "Bearer (Defaults.accessToken)"])
Use of unresolved identifier 'Metadata'

  1. try streamCall.sendMessage(request) { err in
    Ambiguous reference to member 'sendMessage'

  2. try streamCall.sendEnd() {
    Cannot convert value of type '() -> ()' to expected argument type 'EventLoopPromise?'

  3. let response = try streamCall.receive()
    Value of type 'AssistCall' (aka 'BidirectionalStreamingCall<Google_Assistant_Embedded_V1alpha2_AssistRequest, Google_Assistant_Embedded_V1alpha2_AssistResponse>') has no member 'receive'

@hb2708
Copy link
Author

hb2708 commented Feb 19, 2020

Also need to run pod deintegrate and delete the workspace file.

Also i can not find the Package.swift file in this branch

@guruantree
Copy link

Xcode 11.3 #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanshg vanshg Awaiting requested review from vanshg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fail with Xcode 11.3 (11C29)
3 participants
@hb2708 @vanshg @guruantree